[56254] trunk/dports/python

[Ryan Schmidt]

On Aug 25, 2009, at 14:51, jameskyle at macports.org wrote:

> Revision: 56254
>           http://trac.macports.org/changeset/56254
> Author:   jameskyle at macports.org
> Date:     2009-08-25 12:51:52 -0700 (Tue, 25 Aug 2009)
> Log Message:
> -----------
> Added python 2.6 version of pymvpa
>
> Added Paths:
> -----------
>     trunk/dports/python/py26-pymvpa/
>     trunk/dports/python/py26-pymvpa/Portfile
>     trunk/dports/python/py26-pymvpa/files/
>     trunk/dports/python/py26-pymvpa/files/patch-mvpa.diff
>     trunk/dports/python/py26-pymvpa/files/setup-py.diff


> +default_variants        +pywavelet +libsvm +hcluster +pynifti  
> +shogun +scipy

Default variants are difficult for the user to turn off. If you want  
these features enabled by default, why not delete the variants and  
just make the port always build them?

If there really is value in allowing the user to disable these  
features, make them "no_" variants, e.g. "no_pywavelet", "no_libsvm",  
etc.


> +variant scipy description {Add support for scipy libraries} {
> +    depends_lib-append port:py26-scipy
> +}
> +
> +variant pynifti description {Add support for the Nifti file format} {
> +    depends_lib-append port:py26-pynifti
> +}
> +
> +variant hcluster description {perform cluster analysis and plot  
> dendograms of results} {
> +    depends_lib-append port:py26-hcluster
> +}

> +variant matplotlib description {include support for the matplotlib  
> library} {
> +    ui_msg "The default matplotlib build may fail to compile."
> +    ui_msg "If this is the case, please build with +wxpython  
> variant."
> +    depends_lib-append port:py26-matplotlib
> +}
> +
> +variant pywavelet description {include support for pywavelet  
> module} {
> +    depends_lib-append port:py26-pywavelets
> +}
> +
> +variant shogun description {compile support for the python shogun  
> classifiers} {
> +    depends_lib-append port:shogun
> +}

Variants must do more than just add a dependency. They must also  
inform the software it is ok to use that dependency -- like you did  
in this variant:

> +variant libsvm description {compile the libsvm classifier  
> extension} {
> +    depends_lib-append port:libsvm \
> +                       port:swig
> +    configure.args-append --with-libsvm
> +}