[61596] trunk/dports/graphics/wxWidgets/Portfile

[Ryan Schmidt]

On Dec 16, 2009, at 13:24, jwa at macports.org wrote:

> Revision: 61596
>          http://trac.macports.org/changeset/61596
> Author:   jwa at macports.org
> Date:     2009-12-16 11:24:42 -0800 (Wed, 16 Dec 2009)
> Log Message:
> -----------
> make wxWidgets build on 10.6, hopefully nothing else breaks
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/wxWidgets/Portfile
> 
> Modified: trunk/dports/graphics/wxWidgets/Portfile
> ===================================================================
> --- trunk/dports/graphics/wxWidgets/Portfile	2009-12-16 18:54:45 UTC (rev 61595)
> +++ trunk/dports/graphics/wxWidgets/Portfile	2009-12-16 19:24:42 UTC (rev 61596)
> @@ -1,6 +1,7 @@
> # $Id$
> 
> PortSystem 1.0
> +PortGroup               archcheck 1.0

There is no reason to add the archcheck portgroup unless you use the archcheck.files directive to check the architectures of the dependencies. However...


On Dec 16, 2009, at 13:24, jwa at macports.org wrote:

> +universal_variant	no
> use_parallel_build no
> 
> +platform darwin 10 {
> +    configure.build_arch	i386
> +#    configure.cflags	"-arch i386"
> +    configure.cppflags	"-arch i386"
> +#    configure.cxxflags	"-arch i386"
> +#    configure.objcflags	"-arch i386"
> +    configure.ldflags	"-arch i386"
> +}

...since you are forcing a 32-bit build, checking the architectures of the dependencies would be an excellent idea.

But why are you forcing a 32-bit build only on Snow Leopard? Wouldn't it also be necessary on Leopard if the user has set build_arch to x86_64 or ppc64?

Attached is a patch for wxWidgets to address these issues.


Unfortunately, the only way this will really be useful for anyone on Snow Leopard is if every port that depends on wxWidgets (I count 20 ports), and every port that depends on those ports (no idea how many), and so on, also forces itself to 32-bit and checks dependencies' architectures. Not pretty.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: wxWidgets.diff
Type: application/octet-stream
Size: 1160 bytes
Desc: not available
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20091216/c1e4e7aa/attachment-0001.obj>