Looking for a portfile review before submitting (rbldnsd)

[Blair Zajac]

Scott Haneda wrote:
> On Jun 10, 2009, at 6:01 PM, Blair Zajac wrote:
>> Scott Haneda wrote:
>>> Hello, I have made a portfile, looking for a quick review, and any 
>>> suggestions for cleanup.
>>>
>>> pre-destroot {
>>>       addgroup _rbldnsd
>>>       set gid [existsgroup _rbldnsd]
>>>       adduser _rbldnsd gid=${gid} realname=rbldnsd home=${prefix}/sbin
>>> }
>>
>> Do we need a new user for this daemon?  How about just using nobody?
> 
> The app does require a user to run, at least, I had to specify one.  Is 
> "nobody" a valid user?  You mean to add in a user of nobody, or just let 
> the user run it with no user specified, or specifically chose nobody?

Nobody is on the system.

$ grep nobody /etc/passwd
nobody:*:-2:-2:Unprivileged User:/var/empty:/usr/bin/false

>> This is redundant information I think, all portfiles behave the same 
>> way, so I don't see why it should be printed.
> 
> Mainly, because this was a strange binary to use. There is no "make 
> install", you get a bunch of files, the Web site does not tell you there 
> is even a man page, and the docs on the Web site I could put in a 
> ui_messages they are so short.  NEWS and TODO were not valuable to me, 
> but README.user was.

Include them all, disk is cheap.

> 
> I could lose the files, but the mention of there being a man page was 
> valuable to me at least.  I will nuke the ui_msg though.

OK.  I do a port contents or look in the doc directory to see what it installed. 
  Using ui_msg to say there is a manual page isn't necessary.

Blair