[53030] trunk/dports/graphics/nifticlib/Portfile

[Jeremy Lavergne]

Shouldn't -append be used here to avoid overwriting the portgroup  
settings for each variable you use?


On Jun 28, 2009, at 7:02 PM, Ryan Schmidt wrote:
> On Jun 28, 2009, at 09:31, jameskyle at macports.org wrote:
>> Ticket #20024
>
> You can also remove these lines from the portfile now, since the  
> cmake portgroup does this for you:
>
> depends_build       port:cmake
> configure.cmd       cmake
>
> I'm not sure about the prefix. Your port does
>
> configure.pre_args
> configure.args      -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
>                    -DBUILD_SHARED_LIBS:BOOL=True
>
> while the cmake portgroup does
>
> configure.pre_args  -DCMAKE_INSTALL_PREFIX=${prefix}
>
> I do not know cmake, but if "-DCMAKE_INSTALL_PREFIX=${prefix}" is  
> equivalent to "-DCMAKE_INSTALL_PREFIX:PATH=${prefix}" then you can  
> reduce the lines
>
> configure.pre_args
> configure.args      -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
>                    -DBUILD_SHARED_LIBS:BOOL=True
>
> to just
>
> configure.args      -DBUILD_SHARED_LIBS:BOOL=True
>
> If they are not equivalent, then I would still recommend you use
>
> configure.pre_args  -DCMAKE_INSTALL_PREFIX:PATH=${prefix}
> configure.args      -DBUILD_SHARED_LIBS:BOOL=True
>
> since configure.pre_args is where the prefix is traditionally set.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2435 bytes
Desc: not available
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20090628/44641e1f/attachment.bin>