[53030] trunk/dports/graphics/nifticlib/Portfile

[Ryan Schmidt]

On Jun 28, 2009, at 09:31, jameskyle at macports.org wrote:

> Revision: 53030
>           http://trac.macports.org/changeset/53030
> Author:   jameskyle at macports.org
> Date:     2009-06-28 07:31:33 -0700 (Sun, 28 Jun 2009)
> Log Message:
> -----------
> Converted to portgroup cmake 1.0 for proper handling of universal  
> variants.
> Ticket #20024

You can also remove these lines from the portfile now, since the  
cmake portgroup does this for you:

depends_build       port:cmake
configure.cmd       cmake

I'm not sure about the prefix. Your port does

configure.pre_args
configure.args      -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
                     -DBUILD_SHARED_LIBS:BOOL=True

while the cmake portgroup does

configure.pre_args  -DCMAKE_INSTALL_PREFIX=${prefix}

I do not know cmake, but if "-DCMAKE_INSTALL_PREFIX=${prefix}" is  
equivalent to "-DCMAKE_INSTALL_PREFIX:PATH=${prefix}" then you can  
reduce the lines

configure.pre_args
configure.args      -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
                     -DBUILD_SHARED_LIBS:BOOL=True

to just

configure.args      -DBUILD_SHARED_LIBS:BOOL=True

If they are not equivalent, then I would still recommend you use

configure.pre_args  -DCMAKE_INSTALL_PREFIX:PATH=${prefix}
configure.args      -DBUILD_SHARED_LIBS:BOOL=True

since configure.pre_args is where the prefix is traditionally set.