Port review of pure-ftpd

[Scott Haneda]

On Oct 27, 2009, at 8:37 PM, Ryan Schmidt wrote:

> On Oct 27, 2009, at 21:58, Scott Haneda wrote:
>
>> I do not really understand the conflicting variants issue, and seem  
>> to be unable to find a lot of documentation on the matter.  In this  
>> case, I know I can not append more than one language to the  
>> configure.args, and wanted to solve that.  I suppose I am ok with  
>> this though.
>
> What questions do you have about conflicting variants? I'll  
> certainly try to answer them.

I get the impression there is a inbuilt mechanism for dealing with  
conflicting variants.  This is why my simple repeat loops to count up  
how many language variants were added was a bad idea, replication of  
tools.

The code you showed me for the swig port, is just barely something I  
can grok as to what it is up to, with the downside that `port variants  
swig` looks a little goofy.

I am mostly just looking for the docs on how to gain a better  
understanding on what is going on in that swig portfile.

>> If someone has a nice and clean way to do it, I am all ears, but  
>> the previous example posted here, I have looked at it a few times,  
>> and to be honest, that seems like a lot of stuff to put in a port  
>> file just to have languages not collide.
>
> The example I submitted not only allows you to specify conflicting  
> variants, but also allows the variants to be constructed  
> programmatically, so that you don't have to repeat stuff in each  
> variant, like you were doing, such as the description. Admittedly  
> the variants themselves, from your previous portfile, are pretty  
> simple; you don't gain as much by constructing them programmatically  
> as the swig port did by doing so.


I would need to adapt the swig code to my case, and get it so that it  
is just adding in the languages, and alerting for conflicts, there  
seems to be a lot more going on there. If you have shove me in the  
right direction, that would be great.

There is not a lot in the docs on "conflicts", all I really want to do  
is iterate a list to add them, and then look at how many are being  
requested to be installed, for the "lang*" ones, and abort if there is  
more than one.

I found other issues in the pure-ftpd port, so I am stalled waiting on  
developer feedback on that, which gives me time to be more ideal about  
this language issue.

Thanks
-- 
Scott * If you contact me off list replace talklists@ with scott@ *