MacPorts on Other Platforms

Ryan Schmidt ryandesign at macports.org
Mon Sep 21 00:33:27 PDT 2009


On Sep 21, 2009, at 02:24, Ryan Schmidt wrote:

>> Besides,
>> that "-j1" argument seemed rather silly to me in the first place ?
>
> Sure. There's just no special case code in there to handle when  
> jobs=1. But like I said it could be easily added. How about this  
> patch?
>
>
> Index: portbuild.tcl
> ===================================================================
> --- portbuild.tcl	(revision 57981)
> +++ portbuild.tcl	(working copy)
> @@ -142,7 +142,7 @@
>         return ""
>     }
>
> -    if {![exists build.jobs] || !([string match "*make*" [option  
> build.cmd]] || [string match "*scons*" [option build.cmd]])} {
> +    if {![exists build.jobs] || 1 == [option build.jobs] || ! 
> ([string match "*make*" [option build.cmd]] || [string match  
> "*scons*" [option build.cmd]])} {
>         return ""
>     }
>     return " -j[option build.jobs]"

Oh, I see now you committed a different fix in r57998. Wouldn't mine  
be simpler?



More information about the macports-dev mailing list