MacPorts on Other Platforms
Anders F Björklund
afb at macports.org
Mon Sep 21 02:47:14 PDT 2009
>> Sure. There's just no special case code in there to handle when
>> jobs=1. But like I said it could be easily added. How about this
>> patch?
>> - if {![exists build.jobs] || !([string match "*make*" [option
>> build.cmd]] || [string match "*scons*" [option build.cmd]])} {
>> + if {![exists build.jobs] || 1 == [option build.jobs] || !
>> ([string match "*make*" [option build.cmd]] || [string match
>> "*scons*" [option build.cmd]])} {
> Oh, I see now you committed a different fix in r57998. Wouldn't
> mine be simpler?
I just restored my original code, which was "simple" to me :-)
Seems like it got lost in the split-and-rewrite of r52390 ?
Feel free to revise it, although I do think you should keep
the integer check on any build.jobs=foo parameters passed...
--anders
More information about the macports-dev
mailing list