[66441] trunk/dports/editors

[David Baumgold]

>
> Begin forwarded message:
>
> > From: Ryan Schmidt <ryandesign at macports.org>
> > Date: April 13, 2010 1:06:03 PM EDT
> > To: macports-dev at lists.macosforge.org, singingwolfboy at macports.org
> > Subject: Re: [66441] trunk/dports/editors
> >
> > On Apr 13, 2010, at 10:39, singingwolfboy at macports.org wrote:
> >
> >> Revision: 66441
> >>         http://trac.macports.org/changeset/66441
> >> Author:   singingwolfboy at macports.org
> >> Date:     2010-04-13 08:39:15 -0700 (Tue, 13 Apr 2010)
> >> Log Message:
> >> -----------
> >> Added port for NERD Tree Vim plugin
> >
> >> +fetch {
> >> +    xinstall -d ${prefix}/var/macports/distfiles/${name}/
> >> +    set dl
> ${prefix}/var/macports/distfiles/${name}/${distname}${extract.suffix}
> >> +    foreach site ${master_sites} {
> >> +        if {[file exists $dl]} {
> >> +            if {[file size $dl] == 0} {
> >> +                system "curl ${site} > ${dl}"
> >> +            }
> >> +        } else {
> >> +            system "curl ${site} > ${dl}"
> >> +        }
> >> +    }
> >> +}
> >
> > Why override the fetch phase?
>

Because the download link is "
http://www.vim.org/scripts/script.php?script_id=1658" exactly: the HTTP
header instructs the browser to save the file as "NERD_tree.zip". I didn't
see any way for the Macports configuration to handle this, but if there is,
I'd love to get rid of this terrible hack.


> >
> >
> >> +    # rebuild help tags
> >> +    system "${prefix}/bin/vim -c \":helptags
> /opt/local/share/vim/vim72/doc\" -c \":q\" "
> >
> > You should use ${prefix}, not hardcode /opt/local. Also it appears that
> here inside the destroot phase, you're doing operations outside of the
> destroot directory.
>

Ack! I'm an idiot. Fixing in a moment.

Jeremy: Is checksumming normally taken care of in the fetch phase? I thought
it was its own separate phase, and so overriding fetch would leave the
checksum step untouched.

Also, is there a way to change where my @macports.org email address forwards
to? I can't seem to reply using my @macports.org address from that account,
so I had to forward the message to my Gmail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20100413/7971011c/attachment.html>