Auto lint reports
Scott Haneda
talklists at newgeo.com
Wed Apr 28 11:22:34 PDT 2010
Hello, I just received 4 lint reports from an automated system in MacPorts. Here is one example:
Change: http://trac.macports.org/changeset/67067
Portfile: p5-file-readbackwards
Warning: Line 19 seems to hardcode the version number, consider using
${version} instead
Here is the port http://pastie.org/939582
# $Id: Portfile 45733 2009-01-21 01:02:41Z blb at macports.org $
PortSystem 1.0
PortGroup perl5 1.0
perl5.setup File-ReadBackwards 1.04
maintainers hostwizard.com:scott
description This module reads a file backwards line by line.
long_description It is simple to use, memory efficient and fast. \
It supports both an object and a tied handle interface. \
\
It is intended for processing log and other similar text \
files which typically have their newest entries appended \
to them. By default files are assumed to be plain text and \
have a line ending appropriate to the OS. But you can set \
the input record separator string on a per file basis.
homepage http://search.cpan.org/~uri/File-ReadBackwards-1.04/
platforms darwin
checksums md5 bda339c8b2e5139649cb28c4b775fb42 \
sha1 19874cb169f2b105c82222588a163fb17bd77599 \
rmd160 ab166d1797b0e95ae8990ee583071337bfb54fdf
A couple questions. Tab stops are set to 8 now, which I never would have done. How does this happen? What is the preferred MacPorts tab stops to use? If I change it, I assume I should do so in two patches, one to fix the version, and one to fix the tab stops?
Is this the correct way to fix this? Do the p5's usually get a livecheck as well? Or is there something built into MP's to make it happen, as a port livecheck on this p5 seems to tell me it is up to date with the -d flag in use.
version 1.04
perl5.setup File-ReadBackwards ${version}
maintainers hostwizard.com:scott
description This module reads a file backwards line by line.
long_description It is simple to use, memory efficient and fast. \
It supports both an object and a tied handle interface. \
\
It is intended for processing log and other similar text \
files which typically have their newest entries appended \
to them. By default files are assumed to be plain text and \
have a line ending appropriate to the OS. But you can set \
the input record separator string on a per file basis.
homepage http://search.cpan.org/~uri/File-ReadBackwards-${version}/
platforms darwin
checksums md5 bda339c8b2e5139649cb28c4b775fb42 \
sha1 19874cb169f2b105c82222588a163fb17bd77599 \
rmd160 ab166d1797b0e95ae8990ee583071337bfb54fdf
Thanks, once I know the right way to deal with this, I will send in the patches for each notification I received.
--
Scott * If you contact me off list replace talklists@ with scott@ *
More information about the macports-dev
mailing list