[63274] trunk/dports/aqua/pgAdmin3/Portfile

[Ryan Schmidt]

On Jan 31, 2010, at 04:02, jwa at macports.org wrote:

> Revision: 63274
>          http://trac.macports.org/changeset/63274
> Author:   jwa at macports.org
> Date:     2010-01-31 02:02:28 -0800 (Sun, 31 Jan 2010)
> Log Message:
> -----------
> version bump to 1.10.1, making it 32-bit on 10.6


> +platform darwin 10 {
> +    configure.build_arch	i386
> +    configure.cppflags	"-arch i386"
> +    configure.ldflags	"-arch i386"
> +}

Shouldn't you rather make it i386 when build_arch is x86_64, and ppc when build_arch is ppc64? It doesn't necessarily have anything to do with the OS version. I'm also surprised you need to manually set cppflags and ldflags; in my experience, MacPorts takes care of that for you. Also, you need to consider any implications for the universal variant.