[68940] trunk/dports/net/mediatomb/Portfile

[Ryan Schmidt]

On Jun 18, 2010, at 09:33, snc at macports.org wrote:

> Revision: 68940
>          http://trac.macports.org/changeset/68940
> Author:   snc at macports.org
> Date:     2010-06-18 07:33:48 -0700 (Fri, 18 Jun 2010)
> Log Message:
> -----------
> ui_msg to notes
> 
> Modified Paths:
> --------------
>    trunk/dports/net/mediatomb/Portfile
> 
> Modified: trunk/dports/net/mediatomb/Portfile
> ===================================================================
> --- trunk/dports/net/mediatomb/Portfile	2010-06-18 14:31:12 UTC (rev 68939)
> +++ trunk/dports/net/mediatomb/Portfile	2010-06-18 14:33:48 UTC (rev 68940)
> @@ -104,33 +104,31 @@
>     configure.args-delete   --disable-libextractor
> }
> 
> -post-install {
> -    if { [variant_isset taglib] } {
> -        ui_msg "******************************************************"
> -        ui_msg "* To use UTF-8 filename and metadata on Mac OS X, add:"
> -        ui_msg "*   <filesystem-charset>UTF-8-MAC</filesystem-charset>"
> -        ui_msg "*   <metadata-charset>UTF-8-MAC</metadata-charset>"
> -        ui_msg "* to <import> section of ~/.mediatomb/config.xml."
> -        ui_msg "******************************************************"
> -    }
> -    if { [variant_isset mysql4] || [variant_isset mysql5] } {
> -        ui_msg "******************************************************"
> -        ui_msg "* In order to use MySQL for MediaTomb database:"
> -        ui_msg "* 1. Create DB on mysqld and grant all privilege to DB user."
> -        ui_msg "* 2. Run \"mediatomb\" once on your shell."
> -        ui_msg "* 3. Edit auto-generated ~/.mediatomb/config.xml."
> -        ui_msg "*    In <server> section, edit <mysql> config like this:"
> -        ui_msg "*    <mysql enabled=\"yes\">"
> -        ui_msg "*      <host>localhost</host>"
> -        ui_msg "*      <username>dbusername</username>"
> -        ui_msg "*      <password>dbpassword</password>"
> -        ui_msg "*      <database>dbname</database>"
> -        ui_msg "*    </mysql>"
> -        ui_msg "* If sqlite3 is enabled,"
> -        ui_msg "*    <sqlite3 enabled=\"no\">"
> -        ui_msg "* is also needed to disable it."
> -        ui_msg "******************************************************"
> -    }
> +if { [variant_isset taglib] } {
> +    notes "******************************************************
> +* To use UTF-8 filename and metadata on Mac OS X, add:
> +*   <filesystem-charset>UTF-8-MAC</filesystem-charset>
> +*   <metadata-charset>UTF-8-MAC</metadata-charset>
> +* to <import> section of ~/.mediatomb/config.xml.
> +******************************************************"
> }
> +if { [variant_isset mysql4] || [variant_isset mysql5] } {
> +    notes "******************************************************
> +* In order to use MySQL for MediaTomb database:
> +* 1. Create DB on mysqld and grant all privilege to DB user.
> +* 2. Run \"mediatomb\" once on your shell.
> +* 3. Edit auto-generated ~/.mediatomb/config.xml.
> +*    In <server> section, edit <mysql> config like this:
> +*    <mysql enabled=\"yes\">
> +*      <host>localhost</host>
> +*      <username>dbusername</username>
> +*      <password>dbpassword</password>
> +*      <database>dbname</database>
> +*    </mysql>
> +* If sqlite3 is enabled,
> +*    <sqlite3 enabled=\"no\">
> +* is also needed to disable it.
> +******************************************************"
> +}

This is not a good change. Now, if a mysql variant is set, the notes for the taglib variant are not displayed, because you have overwritten those notes.