Compiling from source (was Re: [78061] trunk/dports/devel/premake/Portfile)
Blair Zajac
blair at orcaware.com
Thu Apr 21 17:16:31 PDT 2011
On Apr 21, 2011, at 5:09 PM, Ryan Schmidt wrote:
>
> On Apr 21, 2011, at 19:08, Blair Zajac wrote:
>
>>
>> On Apr 21, 2011, at 5:06 PM, Ryan Schmidt wrote:
>>
>>>
>>> On Apr 21, 2011, at 16:04, wyuenho at macports.org wrote:
>>>
>>>> Revision: 78061
>>>> http://trac.macports.org/changeset/78061
>>>> Author: wyuenho at macports.org
>>>> Date: 2011-04-21 14:04:08 -0700 (Thu, 21 Apr 2011)
>>>> Log Message:
>>>> -----------
>>>> updated premake to 3.7
>>>
>>> You also made whitespace changes; we'd like to see whitespace changes as separate commits from functional changes, so functional changes can be more easily reviewed.
>>>
>>> You also switched from downloading the source and building it, to downloading and installing a binary. Why this change? MacPorts is a build-from-source package manager, deviating only when source is not available or cannot be easily compiled.
>>
>> I agree in general, but for Java packages, I don't see the point in compiling from source, unless we're applying patches.
>
> I didn't realize this was a Java package.
>
I'm not saying it is, and I don't think it is (haven't checked), I was addressing the point about building from source.
Blair
More information about the macports-dev
mailing list