[87734] trunk/dports/graphics/dcmtk/Portfile

[Ryan Schmidt]

On Dec 2, 2011, at 20:16, eborisch at macports.org wrote:

> Revision: 87734
>          http://trac.macports.org/changeset/87734
> Author:   eborisch at macports.org
> Date:     2011-12-02 18:16:12 -0800 (Fri, 02 Dec 2011)
> Log Message:
> -----------
> dcmtk: Prevent building with clang (XCode 4.2 on 10.7) as dcmtk won't build without changes on clang. (Requires 'this->' to be insterted in numerous methods.)
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/dcmtk/Portfile
> 
> Modified: trunk/dports/graphics/dcmtk/Portfile
> ===================================================================
> --- trunk/dports/graphics/dcmtk/Portfile	2011-12-02 22:39:55 UTC (rev 87733)
> +++ trunk/dports/graphics/dcmtk/Portfile	2011-12-03 02:16:12 UTC (rev 87734)
> @@ -75,6 +75,11 @@
> 
> use_parallel_build      no
> 
> +if { [string equal ${configure.compiler} "clang"] } {
> +   ui_warn                 "Cannot compiler with clang; using llvm"
> +   variant_set             llvm
> +}
> +
> variant llvm description "Use llvm compiler" {
>   if { [file exists /usr/bin/llvm-g++-4.2] == 1 } {
>     configure.compiler    llvm-gcc-4.2

Why not do this the way we do all the other ports that need this:

https://trac.macports.org/wiki/PortfileRecipes#compiler

I suggest you remove the llvm variant, and just make the port use llvm-gcc-4.2 if it would otherwise have used clang (as in the wiki page).