[88013] trunk/dports/textproc/dblatex/Portfile

[Rainer Müller]

On 12/16/2011 01:25 AM, Ryan Schmidt wrote:
>> Modified: trunk/dports/textproc/dblatex/Portfile
>> ===================================================================
>> --- trunk/dports/textproc/dblatex/Portfile	2011-12-16 00:12:22 UTC (rev 88012)
>> +++ trunk/dports/textproc/dblatex/Portfile	2011-12-16 00:14:58 UTC (rev 88013)
>> @@ -1,4 +1,4 @@
>> -# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=Portfile:et:sw=4:ts=4:sts=4
>
> Can we talk more about this modeline change? The port was using the standard modeline from the guide, and now it's not.

If we would want to enforce a standard modeline we wouldn't need it at 
all. Everyone could just configure their editor to use these settings. I 
guess it's fine to let the maintainer change the modeline to their liking.

Quite similar, we also require everyone to change their 
.subversion/config to set the correct properties on Portfiles [1].

Regarding the rules enforced by our standard modeline, personally I am 
happy if at least a single Portfile use either spaces or tabs for 
indentation but not both in a misleading fashion (spaces are preferred 
as they still look the same with many different editor configurations). 
The UTF-8 encoding isn't necessary for most Portfiles as they contain 
ASCII only.

Rainer

[1] 
https://trac.macports.org/wiki/CommittersTipsAndTricks#SetsvnpropertiesautomaticallyonnewPortfiles