[75877] trunk/dports/databases

[Bradley Giesbrecht]

On Feb 11, 2011, at 1:39 PM, Ryan Schmidt wrote:

> On Feb 11, 2011, at 14:29, pixilla at macports.org wrote:
>
>> Revision: 75877
>>         http://trac.macports.org/changeset/75877
>> Author:   pixilla at macports.org
>> Date:     2011-02-11 12:29:48 -0800 (Fri, 11 Feb 2011)
>> Log Message:
>> -----------
>> databases/GeoLiteCity: new port adds GeoIPCity.dat data file for  
>> use with port:libgeoip.
>
>> +distname            GeoLiteCity.dat
>
> Since there is no version number in the distfile name, you should  
> have set dist_subdir. See:
>
> https://trac.macports.org/wiki/PortfileRecipes#unversioned-distfiles
>
> I would say don't do it now (no need to force another download of  
> this same file right now), but remember it next time you update the  
> version --
>
> -- except that I currently get a checksum mismatch, so you should  
> fix that and the above at the same time.

Ya, I don't know what to do. geolite.maxmind.com updates the download  
monthly and the path stays the same. I'm looking for an alternate  
download.

Thanks for all below.

>> +pre-extract {
>> +    xinstall -m 755 -d ${worksrcpath}
>> +}
>
> Or more simply: "extract.mkdir yes"
>
>
>> +extract.post_args   > ${worksrcdir}/${distname}
>
> Needs to be worksrcpath, not worksrcdir; don't assume what the  
> current working directory will be.
>
>
>> +use_configure       no
>> +build {}
>> +
>> +destroot  {
>> +    set datadir ${destroot}${prefix}/share/GeoIP
>> +    xinstall -m 755 -d ${datadir}
>> +    xinstall ${worksrcpath}/${distname} ${datadir}/GeoIPCity.dat
>> +}
>
> Since there's no architecture-specific files, this portfile needs  
> "supported_archs noarch". Increase the revision when you add this to  
> force a rebuild so the correct architectures get recorded in the  
> registry.
>
>
> Attached is a patch addressing these issues.
>
>
> <GeoLiteCity-20110202.diff>