[86730] trunk/dports/sysutils/rmtrash/Portfile

[Ryan Schmidt]

On Nov 2, 2011, at 06:08, usami-k at macports.org wrote:

> Revision: 86730
>          http://trac.macports.org/changeset/86730
> Author:   usami-k at macports.org
> Date:     2011-11-02 04:07:58 -0700 (Wed, 02 Nov 2011)
> Log Message:
> -----------
> add livecheck and license
> 
> Modified Paths:
> --------------
>    trunk/dports/sysutils/rmtrash/Portfile
> 
> Modified: trunk/dports/sysutils/rmtrash/Portfile
> ===================================================================
> --- trunk/dports/sysutils/rmtrash/Portfile	2011-11-02 09:15:56 UTC (rev 86729)
> +++ trunk/dports/sysutils/rmtrash/Portfile	2011-11-02 11:07:58 UTC (rev 86730)
> @@ -2,8 +2,9 @@
> PortSystem      1.0
> name            rmtrash
> version         0.3.3
> -revision        1
> +revision        2

Since this does not change the files that get installed by the port, there was no reason to force users to rebuild by increasing the revision.


> maintainers     usami-k
> +license         free

"free" is not a license we're familiar with. See if any of the good_licenses listed here are applicable to this package:

https://trac.macports.org/browser/trunk/base/portmgr/jobs/port_binary_distributable.tcl?rev=86197#L24


> @@ -13,6 +14,7 @@
> homepage        http://www.nightproductions.net/
> master_sites    http://www.nightproductions.net/downloads/
> distname        ${name}_source
> +livecheck.type  moddate

You can improve the livecheck by getting the actual version out of the web page. See attached patch.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmtrash-livecheck.diff
Type: application/octet-stream
Size: 900 bytes
Desc: not available
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20111102/db59862a/attachment.obj>