[83549] trunk/dports/math

[Ryan Schmidt]

On Sep 5, 2011, at 12:12, mww at macports.org wrote:

> Revision: 83549
>          http://trac.macports.org/changeset/83549
> Author:   mww at macports.org
> Date:     2011-09-05 10:12:17 -0700 (Mon, 05 Sep 2011)
> Log Message:
> -----------
> new port: math/minisat
> 
> Added Paths:
> -----------
>    trunk/dports/math/minisat/
>    trunk/dports/math/minisat/Portfile
>    trunk/dports/math/minisat/files/
>    trunk/dports/math/minisat/files/patch-mtl-template.mk.diff
>    trunk/dports/math/minisat/files/patch-utils-System.cc.diff
> 
> Added: trunk/dports/math/minisat/Portfile
> ===================================================================
> --- trunk/dports/math/minisat/Portfile	                        (rev 0)
> +++ trunk/dports/math/minisat/Portfile	2011-09-05 17:12:17 UTC (rev 83549)
> @@ -0,0 +1,42 @@
> +# $Id: Portfile 63716 2010-02-13 13:52:50Z raimue at macports.org $

Don't forget to set the standard svn:keywords (Id) and svn:eol-style (native).

Also add the standard modeline, and ensure the port conforms to it. (Your port does not: it includes a mixture of tabs and spaces for whitespace; we want all spaces.)


> +depends_build       port:gmake

Is the gmake port really required? We recently had a thread in which it was requested that we avoid unnecessary dependencies, so I just want to make sure that you verified that the gmake that Xcode provides was not sufficient.


> +use_configure       no
> 
> +build {
> +    system "cd ${worksrcpath}/simp && MROOT=${worksrcpath} ${prefix}/bin/gmake rs CXX=\"${configure.cxx} ${configure.ldflags} ${configure.cppflags} ${configure.cxxflags}\""
> +}

Remember you also need to use the right architectures. Put [get_canonical_archflags] in with your CFLAGS/CXXFLAGS/LDFLAGS.

You may also then be able to easily add a universal variant by putting the line "variant universal {}" somewhere before this.

We also have a shortcut now where you don't need to "cd"; you can use the "-W" argument:

system -W ${worksrcpath}/simp "MROOT=${worksrcpath} ..."


> +destroot {
> +    xinstall -m 755 -d ${destroot}${prefix}/bin \

MacPorts makes this directory (and all others that are part of the mtree) for you; you don't need to manually.