[94452] trunk/dports/www/nginx/Portfile

[Ryan Schmidt]

On Jun 19, 2012, at 15:16, cal at macports.org wrote:

> Revision: 94452
>          https://trac.macports.org/changeset/94452
> Author:   cal at macports.org
> Date:     2012-06-19 13:16:13 -0700 (Tue, 19 Jun 2012)
> Log Message:
> -----------
> nginx: Add uploadprogress module, closes #34911
> 
> Modified Paths:
> --------------
>    trunk/dports/www/nginx/Portfile

> +variant upload_progress description {Enable Brice Figureau's upload progress module (https://github.com/masterzen/nginx-upload-progress-module)} {
> +    set uploadprg_filename  nginx_uploadprogress_module
> +    set uploadprg_version   0.9.0
> +    set uploadprg_distname  ${uploadprg_filename}-${uploadprg_version}
> +    distfiles-append        ${uploadprg_distname}.tar.gz:uploadprogress_module
> +    post-extract {
> +        move [glob ${workpath}/masterzen-nginx-upload-progress-module-a788dea] ${workpath}/nginx_uploadprogress_module-0.9.0
> +    }
> +    checksums-append        ${uploadprg_distname}.tar.gz \
> +                            rmd160  10ff91748a06afd81abb9fdb203f164ea369463a \
> +                            sha256  3fb903dab595cf6656fa0fc5743a48daffbba2f6b5c554836be630800eaad4e2
> +    configure.args-append   --add-module=${workpath}/${uploadprg_distname}
> +}
> +
> variant xslt description {Post-process pages with XSLT} {
>     configure.args-append   --with-http_xslt_module
> }

Instead of having an ever-increasing number of variants for additional modules, would it be better to have subports? That way users could install subports for additional modules after the fact without having to rebuild the main port. The buildbot would be able to build and distribute them too (assuming compatible licenses)—the buildbot does not build non-default variants.