[90393] trunk/dports/lang/sbcl/Portfile

[Ryan Schmidt]

On Mar 4, 2012, at 07:11, easieste at macports.org wrote:

> Revision: 90393
>          http://trac.macports.org/changeset/90393
> Author:   easieste at macports.org
> Date:     2012-03-04 05:10:59 -0800 (Sun, 04 Mar 2012)
> Log Message:
> -----------
> lang/sbcl: passes port lint and human inspection of output.

I pick further nits! See below.


> -long_description	\
> -    Steel Bank Common Lisp (SBCL) is a Open Source		\
> -    development system for ANSI Common Lisp. It provides an	\
> -    interactive environment including an integrated native	\
> -    compiler, interpreter, and debugger. (And it, and its	\
> -                                              generated code, can also play nicely with Unix when	\
> -                                              running noninteractively.)
> 
> +long_description { 
> +Steel Bank Common Lisp (SBCL) is a Open Source development system for
> +ANSI Common Lisp. It provides an interactive environment including an
> +integrated native compiler, interpreter, and debugger. (And it, and
> +its generated code, can also play nicely with Unix when running
> +noninteractively.)
> +}

This method of storing the long description is unusual and introduces hard line breaks into the long description. Now, with a terminal width of 80 characters, port info output looks like this:


$ port info sbcl
sbcl @1.0.55, Revision 1 (lang)
Variants:             html, pdf, threads

Description:           
                      Steel Bank Common Lisp (SBCL) is a Open Source development
                      system for
                      ANSI Common Lisp. It provides an interactive environment
                      including an
                      integrated native compiler, interpreter, and debugger.
                      (And it, and
                      its generated code, can also play nicely with Unix when
                      running
                      noninteractively.)
                      
Homepage:             http://www.sbcl.org

Platforms:            darwin
License:              unknown
Maintainers:          openmaintainer at macports.org, easieste at macports.org,
                      gwright at macports.org, waqar at macports.org


Whereas before it was stored as a single line, and MacPorts was able to introduce line breaks in the correct places, regardless of terminal width:


$ port info sbcl
sbcl @1.0.55, Revision 1 (lang)
Variants:             html, pdf, threads

Description:          Steel Bank Common Lisp (SBCL) is a Open Source development
                      system for ANSI Common Lisp. It provides an interactive
                      environment including an integrated native compiler,
                      interpreter, and debugger. (And it, and its generated
                      code, can also play nicely with Unix when running
                      noninteractively.)
Homepage:             http://www.sbcl.org

Platforms:            darwin
License:              unknown
Maintainers:          openmaintainer at macports.org, easieste at macports.org,
                      gwright at macports.org, waqar at macports.org


> -variant threads description {Enable multi-threaded runtime.} {
> +variant threads description {Enable multi-threaded runtime.
> +(Enabled by default).
> +} {

We don't manually add wording like "Enabled by default" to variant descriptions; MacPorts automatically indicates which variants are enabled by default when you use the default_variants command. For example the pango port:

$ port variants pango
pango has the variants:
   builtin_modules: Build the modules into Pango statically (most users do not need this
                    variant)
   no_x11: Legacy compatibility variant
     * conflicts with x11
   quartz: Support for native Mac OS X graphics
(+)universal: Build for multiple architectures
[+]x11: Enable X11 support

The "[+]" before the x11 variant indicates that it is a default variant of the port and will be automatically selected. (The "(+)" before the universal variant indicates that it will also be automatically selected, but only because I have placed "+universal" into my variants.conf file.)

In the case of sbcl, it does not appear as though the threads variant is actually enabled by default. If you want it to be, add the line "default_variants +threads".