[91233] trunk/dports/databases/mysql55/Portfile

[Joshua Root]

On 2012-3-27 21:46 , Rainer Müller wrote:
> On 03/27/2012 02:49 AM, Ryan Schmidt wrote:
>>> Modified: trunk/dports/databases/mysql55/Portfile
>>> ===================================================================
>>> --- trunk/dports/databases/mysql55/Portfile	2012-03-26 15:08:04 UTC (rev 91232)
>>> +++ trunk/dports/databases/mysql55/Portfile	2012-03-26 15:24:06 UTC (rev 91233)
>>> @@ -13,7 +13,7 @@
>>> platforms           darwin
>>> maintainers         pixilla openmaintainer
>>>
>>> -subport mysql55 {
>>> +if {$subport == $name} {
>>
>> So wait, this actually causes a problem? That's unfortunate, and it means I have several places where I need to undo this.
> 
> I think the current terminology means that if $subport equals $name,
> then this is should not be a subport at all, but the "main" port. For
> this mysql55 port, the subports mysql55 and mysql55-server are quite
> different and probably should not be implemented as a subport.

I never imagined that someone would write "subport foo" when they are
already defining the foo port outside of any subport block. It's kind of
like having a variant called "none" and setting it when no other
variants are set.

> I don't like this syntax either and it is confusing to me. Maybe we
> could handle this as a special case to allow use of a clear syntax
> without implying a difference on the "main" port and other subports?

It's ironic that avoiding a difference requires *more* special casing.

- Josh