[91233] trunk/dports/databases/mysql55/Portfile

[Ryan Schmidt]

On Mar 27, 2012, at 08:00, Joshua Root wrote:
> On 2012-3-27 21:46 , Rainer Müller wrote:
>> On 03/27/2012 02:49 AM, Ryan Schmidt wrote:
>>>> Modified: trunk/dports/databases/mysql55/Portfile
>>>> ===================================================================
>>>> --- trunk/dports/databases/mysql55/Portfile	2012-03-26 15:08:04 UTC (rev 91232)
>>>> +++ trunk/dports/databases/mysql55/Portfile	2012-03-26 15:24:06 UTC (rev 91233)
>>>> @@ -13,7 +13,7 @@
>>>> platforms           darwin
>>>> maintainers         pixilla openmaintainer
>>>> 
>>>> -subport mysql55 {
>>>> +if {$subport == $name} {
>>> 
>>> So wait, this actually causes a problem? That's unfortunate, and it means I have several places where I need to undo this.
>> 
>> I think the current terminology means that if $subport equals $name,
>> then this is should not be a subport at all, but the "main" port. For
>> this mysql55 port, the subports mysql55 and mysql55-server are quite
>> different and probably should not be implemented as a subport.
> 
> I never imagined that someone would write "subport foo" when they are
> already defining the foo port outside of any subport block.

No, outside of any subport block, they're defining global things shared by all subports.

Again, what actual problem does writing e.g. "subport mysql55" in the mysql55 port cause? As I said, I'm already doing this in several other ports and was not aware this caused any problem.