[92915] trunk/dports/fuse

[Ryan Schmidt]

On May 10, 2012, at 11:31, phw at macports.org wrote:

> Revision: 92915
>          https://trac.macports.org/changeset/92915
> Author:   phw at macports.org
> Date:     2012-05-10 09:31:22 -0700 (Thu, 10 May 2012)
> Log Message:
> -----------
> New port: offlinefs, a offline-layer of filesystems (fuse)
> 
> Added Paths:
> -----------
>    trunk/dports/fuse/offlinefs/
>    trunk/dports/fuse/offlinefs/Portfile
>    trunk/dports/fuse/offlinefs/files/
>    trunk/dports/fuse/offlinefs/files/patch-src-Makefile.am.diff
>    trunk/dports/fuse/offlinefs/files/patch-src-Makefile.in.diff
> 
> Added: trunk/dports/fuse/offlinefs/Portfile
> ===================================================================
> --- trunk/dports/fuse/offlinefs/Portfile	                        (rev 0)
> +++ trunk/dports/fuse/offlinefs/Portfile	2012-05-10 16:31:22 UTC (rev 92915)
> @@ -0,0 +1,44 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem 1.0
> +
> +name                offlinefs
> +version             0.4.6
> +categories          fuse
> +
> +platforms           darwin
> +maintainers         phw openmaintainer
> +description         Fusefs offline layer able to extend every filesystem with offline capabilities
> +long_description    The OFS (Offline FileSystem or Ohm FileSystem) is an \
> +                    offline-layer which is (or should be) able to extend \
> +                    every filesystem with offline capabilities. This means, \
> +                    that the user is able to work on his network documents, \
> +                    even when he is disconnected from the server. When \
> +                    connection is restored, the filesystem automatically synchronizes the files.
> +                    
> +homepage            http://offlinefs.sourceforge.net/wiki/
> +
> +master_sites        sourceforge:offlinefs

You should write sourceforce master_sites in such a way that redirects are minimized. See tons of commits in other ports over the past months for examples.

> +license             GPL-2
> +
> +checksums           rmd160  a56cc9459ae5d261608bc2373baa73bc3063af4a \
> +                    sha256  36913bb52e23be7c033949894677ae94f40df1e25f56e14458bd63b83d7f1156
> +livecheck.distname  offlinefs
> +
> +use_autoreconf      yes
> +
> +depends_build       port:automake \
> +                    port:autoconf \
> +                    port:libtool  \
> +                    port:gcc45 

In what way does this port use gcc45?


> +depends_lib         port:fuse4x \
> +                    port:dbus-devel \
> +                    port:libconfuse 

Does this port really need dbus-devel? dbus is not sufficient? If so that's unfortunate since it conflicts with dbus and lots of ports need dbus. Also, dbus-devel doesn't build for me.


> +patchfiles          patch-src-Makefile.in.diff \
> +                    patch-src-Makefile.am.diff

One or the other. You only need to patch Makefile.am if you're running autoreconf. You only need to patch Makefile.in if you're not running autoreconf.


> +pre-destroot {
> +    file mkdir ${destroot}/sbin
> +    }

Since you're patching the Makefile to not install in /sbin, why do you need to create /sbin?


Finally, the buildbot failed to build this port.