[104965] trunk/dports/sysutils/smart/Portfile

[Ryan Schmidt]

On Apr 6, 2013, at 04:37, afb at macports.org wrote:

> Revision: 104965
>          https://trac.macports.org/changeset/104965
> Author:   afb at macports.org
> Date:     2013-04-06 02:37:39 -0700 (Sat, 06 Apr 2013)
> Log Message:
> -----------
> smart: replace optional dependency (#38457)
> 
> Modified Paths:
> --------------
>    trunk/dports/sysutils/smart/Portfile
> 
> Modified: trunk/dports/sysutils/smart/Portfile
> ===================================================================
> --- trunk/dports/sysutils/smart/Portfile	2013-04-06 06:55:37 UTC (rev 104964)
> +++ trunk/dports/sysutils/smart/Portfile	2013-04-06 09:37:39 UTC (rev 104965)
> @@ -44,9 +44,9 @@
> test.args-append	PYTHON="${prefix}/bin/python2.4"
> 
> variant rpm5 description "use rpm5, not rpm4" {
> -	# uses RPM 5.0.3, instead of the default RPM 4.4.9
> +	# uses RPM 5.2.1, instead of the default RPM 4.4.9
> 	depends_lib-delete	lib:librpm:rpm port:python24
> -	depends_lib-append	lib:librpm-5.0:rpm50 port:python25
> +	depends_lib-append	lib:librpm-5.2:rpm52 port:python25
> 	#depends_run		port:py25-gtk
> 	build.args-delete	PYTHON="${prefix}/bin/python2.4"
> 	build.args-append	PYTHON="${prefix}/bin/python2.5"

This should be using port:-style dependencies, not lib:-style. lib:-style allows libraries installed outside of MacPorts to satisfy the dependency, and this is usually not desirable.