[109567] users/mojca/wxports

[Ryan Schmidt]

On Aug 17, 2013, at 11:57, mojca at macports.org wrote:

> Revision: 109567
>          https://trac.macports.org/changeset/109567
> Author:   mojca at macports.org
> Date:     2013-08-17 09:57:19 -0700 (Sat, 17 Aug 2013)
> Log Message:
> -----------
> mojca/usbprog: update to version 0.2.1, adapt for different wxWidgets versions, take sources from bitbucket, update url
> 
> Modified Paths:
> --------------
>    users/mojca/wxports/cross/usbprog/Portfile

> +    # TODO: not sure how to prevent duplication of the following code
> +    # TODO: if needed, an additional variable could be added to wxwidgets PortGroup for easier access to wxwin.m4
> +    pre-configure {
> +        system "mkdir ${worksrcpath}/m4"
> +        system "cp ${wxWidgets.prefix}/share/aclocal/wxwin.m4 ${worksrcpath}/m4/"
> +        system "cd ${worksrcpath} && ./bootstrap"
> +    }
> +}

Please avoid using "system" for tasks that can be accomplished directly in Tcl. For example:

file mkdir ${worksrcpath}/m4
copy ${wxWidgets.prefix}/share/aclocal/wxwin.m4 ${worksrcpath}/m4/
system -W ${worksrcpath} "./bootstrap"