[102536] trunk/dports/python/py-hgsubversion/Portfile

[Ryan Schmidt]

On Feb 4, 2013, at 17:13, Sean Farley wrote:

> On Mon, Feb 4, 2013 at 5:08 PM, Ryan Schmidt wrote:
>> 
>>> For example, py-yaml or py-bottle both overwrite categories with 'python devel'.
>> 
>> Yes but that's not a problem. Since the python portgroup sets categories to python, setting categories to python devel is exactly equivalent to appending devel to the categories.
> 
> … then I'm confused as to the initial compliant given by Frank, "Why
> did you change this? The python 1.0 portgroup sets the category as
> python. The way it was is how we do it on all the other python ports."

The complaint was that although your change did not have any functional effect on the port, you changed the port from using the recommended method (appending to the values the portgroup sets for you) to the not-recommended method (redundantly specifying / overwriting things the portgroup sets for you).

> I guess it's because I didn't realize that python-1.0.tcl already sets
> the python category … but then again, having 125 ports set a bad
> example means there's a high probability that a new port author will
> use them as a template.

That's true.