[103156] trunk/dports/textproc/libxls/Portfile

[Ryan Schmidt]

On Feb 16, 2013, at 05:46, nicos at macports.org wrote:

> Revision: 103156
>          https://trac.macports.org/changeset/103156
> Author:   nicos at macports.org
> Date:     2013-02-16 03:46:17 -0800 (Sat, 16 Feb 2013)
> Log Message:
> -----------
> libxls: upgrade to 1.3.2
> 
> Modified Paths:
> --------------
>    trunk/dports/textproc/libxls/Portfile
> 
> Modified: trunk/dports/textproc/libxls/Portfile
> ===================================================================
> --- trunk/dports/textproc/libxls/Portfile	2013-02-16 11:06:55 UTC (rev 103155)
> +++ trunk/dports/textproc/libxls/Portfile	2013-02-16 11:46:17 UTC (rev 103156)
> @@ -4,7 +4,7 @@
> PortSystem          1.0
> 
> name                libxls
> -version             1.3.1
> +version             1.3.2
> categories          textproc
> maintainers         nicos openmaintainer
> platforms           darwin
> @@ -19,7 +19,9 @@
> 
> worksrcdir          ${name}
> 
> -checksums           rmd160  03aa804fa083ecf9acac0898350af67748cae1d0 \
> -                    sha256  6b8e081392786753936106701a7befca005cd2003e7805f133be4511b5608176
> +checksums           rmd160  9ff79cdf70884ad667b8f720f628add1a42f04a5 \
> +                    sha256  fe560f8f42c2cb1b278b35bef296c244e1b44f453f4f8ae5f7b5ad0ca4bc0716
> 
> +configure.cflags    -DHAVE_ASPRINTF=1

This overwrites the default cflags. Is that what you want? The default for configure.cflags is configure.optflags, whose default is -O2. So by overwriting, you're no longer getting optimizations. You might want to append to cflags to retain them instead.

Looks like the reason why you have to manually set -DHAVE_ASPRINTF=1 is because the project's configure script does not check for and define it automatically. Looks like the check is in configure.in; seems like configure was not regenerated from configure.in before the 1.2.1 release -- or, looking at the comment at the top of the configure file, at all after the 1.0.0 release:


$ head -n 3 configure
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.61 for libxls 1.0.0.


Have you reported this problem to the developers of libxls already? If so, you could put the URL of the bug report or mailing list discussion in a comment above that line in the portfile, to remind yourself to remove it later once upstream resolves it.