[103156] trunk/dports/textproc/libxls/Portfile

[Nicolas Pavillon]

Hello, 

> This overwrites the default cflags. Is that what you want? The default for configure.cflags is configure.optflags, whose default is -O2. So by overwriting, you're no longer getting optimizations. You might want to append to cflags to retain them instead.

You are totally right, I just overlooked it. Corrected in r103203.
Thanks for the comment.

> 
> Looks like the reason why you have to manually set -DHAVE_ASPRINTF=1 is because the project's configure script does not check for and define it automatically. Looks like the check is in configure.in; seems like configure was not regenerated from configure.in before the 1.2.1 release -- or, looking at the comment at the top of the configure file, at all after the 1.0.0 release:
> 
> 
> $ head -n 3 configure
> #! /bin/sh
> # Guess values for system-dependent variables and create Makefiles.
> # Generated by GNU Autoconf 2.61 for libxls 1.0.0.
> 
> 
> Have you reported this problem to the developers of libxls already? If so, you could put the URL of the bug report or mailing list discussion in a comment above that line in the portfile, to remind yourself to remove it later once upstream resolves it.

Not yet, but will do it. I upgraded it with other ports I wanted to look at, and did not take the time to do report it upstream yet. Will correct that soon.