[103398] trunk/dports/lang

[Ryan Schmidt]

On Feb 24, 2013, at 12:31, jann at macports.org wrote:

> Revision: 103398
>          https://trac.macports.org/changeset/103398
> Author:   jann at macports.org
> Date:     2013-02-24 10:31:10 -0800 (Sun, 24 Feb 2013)
> Log Message:
> -----------
> new eiffelstudio version
> 
> Added Paths:
> -----------
>    trunk/dports/lang/eiffelstudio72/
>    trunk/dports/lang/eiffelstudio72/Portfile
> 
> Added: trunk/dports/lang/eiffelstudio72/Portfile
> ===================================================================
> --- trunk/dports/lang/eiffelstudio72/Portfile	                        (rev 0)
> +++ trunk/dports/lang/eiffelstudio72/Portfile	2013-02-24 18:31:10 UTC (rev 103398)
> @@ -0,0 +1,99 @@
> +# $Id: Portfile 98512 2012-10-07 18:59:57Z jann at macports.org $

Don't forget to set svn:keywords to Id and svn:eol-style to native on new Portfiles. You can set up Subversion to do this automatically for you:

https://trac.macports.org/wiki/CommittersTipsAndTricks#SetsvnpropertiesautomaticallyonnewPortfiles


> +license           GPL

If you can determine and indicate the specific version(s) of GPL that would be ideal.


> +depends_lib       port:gtk2 \
> +                  lib:libXtst:xorg-libXtst

lib:-style dependencies should almost never be used. They allow non-MacPorts software to satisfy the dependency, and we almost never want that. Use a normal port:-style dependency to ensure only a MacPorts port satisfies it.


> +checksums         ${distname}${extract.suffix} rmd160 51cf3668f93d6f9eeb0a910122414ec23ebf0a13 \
> +                  ${eiffel_launch} rmd160 f52af5b8b09ecdd21af4b1d89d2716597a9c1340

Each file should have at least two checksum types.


> +build             {                   
> +                    system "cd ${worksrcpath} && ${worksrcpath}/compile_exes $ise_platform"

Instead of using "cd" in a system call, you should use the system command's -W argument:

system -W ${worksrcpath} "${worksrcpath}/compile_exes $ise_platform"


I haven't checked the other eiffelstudio ports; these comments might apply to them too.