[106995] trunk/dports/aqua/qtiplot/Portfile

[Nicolas Pavillon]

Hello, 

On Jun 14, 2013, at 3:51 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
> Does this commit cause any changes in the files the port installs? If not, the revision should not have been increased (but don't change it now).

There was a ticket mentioning that qtiplot was not necessarily employing the right compiler, while the portgroup does it properly in principle, so that some changes could happen on certain platforms, hence the revbump.

>> @@ -118,8 +114,6 @@
>>    ${worksrcpath}/3rdparty/qwtplot3d/qwtplot3d.pro
>> }
>> 
>> -configure.pre_args  "PREFIX=${prefix}"
>> -configure.cmd   "LOCALSOFT=${prefix} ${qt_qmake_cmd}"
>> destroot.destdir INSTALL_ROOT=${destroot}
> 
> Is use of the LOCALSOFT=${prefix} setting not required? The qmake portgroup doesn't seem to include that directive.

It is not indicated on the installation instructions, and by testing rapidly, I could not see any issues when suppressing it, so I assume it is a historical variable (the port changed significantly in previous versions). Passing to the new portgroup seemed a good occasion to suppress it. 

Cheers, 

Nicolas