[106995] trunk/dports/aqua/qtiplot/Portfile

[Ryan Schmidt]

On Jun 13, 2013, at 11:28, nicos at macports.org wrote:

> Revision: 106995
>          https://trac.macports.org/changeset/106995
> Author:   nicos at macports.org
> Date:     2013-06-13 09:28:25 -0700 (Thu, 13 Jun 2013)
> Log Message:
> -----------
> qtiplot: use qmake portgroup
> 
> Modified Paths:
> --------------
>    trunk/dports/aqua/qtiplot/Portfile
> 
> Modified: trunk/dports/aqua/qtiplot/Portfile
> ===================================================================
> --- trunk/dports/aqua/qtiplot/Portfile	2013-06-13 15:37:18 UTC (rev 106994)
> +++ trunk/dports/aqua/qtiplot/Portfile	2013-06-13 16:28:25 UTC (rev 106995)
> @@ -2,11 +2,11 @@
> # $Id$
> 
> PortSystem  1.0
> -PortGroup           qt4 1.0
> +PortGroup           qmake 1.0
> 
> name                qtiplot
> version             0.9.8.9
> -revision            5
> +revision            6
> categories          aqua science
> license             GPL-2+
> maintainers         nicos openmaintainer

Does this commit cause any changes in the files the port installs? If not, the revision should not have been increased (but don't change it now).


> @@ -118,8 +114,6 @@
>     ${worksrcpath}/3rdparty/qwtplot3d/qwtplot3d.pro
> }
> 
> -configure.pre_args  "PREFIX=${prefix}"
> -configure.cmd   "LOCALSOFT=${prefix} ${qt_qmake_cmd}"
> destroot.destdir INSTALL_ROOT=${destroot}

Is use of the LOCALSOFT=${prefix} setting not required? The qmake portgroup doesn't seem to include that directive.