[106263] trunk/dports/devel/zmq

[Joshua Root]

On 2013-5-21 11:05 , Ryan Schmidt wrote:
> 
> On May 20, 2013, at 18:02, cal at macports.org wrote:
> 
>> Revision: 106263
>>          https://trac.macports.org/changeset/106263
>> Author:   cal at macports.org
>> Date:     2013-05-20 16:02:10 -0700 (Mon, 20 May 2013)
>> Log Message:
>> -----------
>> zmq: Fix a problem where strndup was missing on < lion, closes #39122, maintainer
>>
>> Modified Paths:
>> --------------
>>    trunk/dports/devel/zmq/Portfile
>>
>> Added Paths:
>> -----------
>>    trunk/dports/devel/zmq/files/
>>    trunk/dports/devel/zmq/files/patch-tests-test_disconnect_inproc.cpp.diff
>>
>> Modified: trunk/dports/devel/zmq/Portfile
>> ===================================================================
>> --- trunk/dports/devel/zmq/Portfile	2013-05-20 20:55:10 UTC (rev 106262)
>> +++ trunk/dports/devel/zmq/Portfile	2013-05-20 23:02:10 UTC (rev 106263)
>> @@ -37,6 +37,11 @@
>> depends_build       port:libtool
>> build.args          LIBTOOL=${prefix}/bin/glibtool
>>
>> +# Work-around from upstream, delete debug prints in tests
>> +if {[vercmp ${os.version} 10.9.0] < 0} {
>> +    patchfiles          patch-tests-test_disconnect_inproc.cpp.diff
>> +}
> 
> Do you have reason to believe that a hypothetical OS X 10.6.9 would include strndup? Your commit message says you intend to check for earlier than Lion; in that case, you should instead test for ${os.platform} == "darwin" && ${os.version} < 11.

You mean ${os.major}, of course.

- Josh