[106263] trunk/dports/devel/zmq

Clemens Lang cal at macports.org
Tue May 21 06:35:40 PDT 2013


On Tue, May 21, 2013 at 04:25:21PM +1000, Joshua Root wrote:
> On 2013-5-21 11:05 , Ryan Schmidt wrote:
> >> +# Work-around from upstream, delete debug prints in tests
> >> +if {[vercmp ${os.version} 10.9.0] < 0} {
> >> +    patchfiles          patch-tests-test_disconnect_inproc.cpp.diff
> >> +}
> > Do you have reason to believe that a hypothetical OS X 10.6.9 would
> > include strndup? Your commit message says you intend to check for
> > earlier than Lion; in that case, you should instead test for
> > ${os.platform} == "darwin" && ${os.version} < 11.
> You mean ${os.major}, of course.

You are right, the version check was completely bogus. I just commited
the patch but didn't write it and it seems my review was a little too
quick. Also, I automagically used the correct os.major instead of
os.version in
  http://trac.macports.org/changeset/106277

-- 
Clemens Lang



More information about the macports-dev mailing list