Fix for github-1.0 PortGroup to test
Michael Dickens
michaelld at macports.org
Fri Oct 11 10:12:30 PDT 2013
For some reason I was using just the first-8 hash; no idea why. Moving
to first-9 or longer fixes that issue! Haha .. silly me. I'll push the
string
comparison changes, but leave the 9+ the same. Thanks! - MLD
On Oct 11, 2013, at 12:58 PM, Ryan Schmidt <ryandesign at macports.org>
wrote:
> The regular expression checks for 9 or more hex characters, so that version number like "3" or "20131011" are not interpreted as git commit hashes. So I would not change that part. There's no reason why maintainers who need to use a git commit hash should not be specifying the full 40-character hash. As for the string comparisons, we should change those.
More information about the macports-dev
mailing list