[123768] trunk/base/src/macports1.0/macports.tcl

[Joshua Root]

> Revision: 123768
>           https://trac.macports.org/changeset/123768
> Author:   larryv at macports.org
> Date:     2014-08-13 21:34:03 -0700 (Wed, 13 Aug 2014)
> Log Message:
> -----------
> macports.tcl: Use quieter git sync command.
> 
> pushd and popd print the directory stacks to stdout, which is just
> noise. This seems cleaner than throwing in two redirections.
> 
> Modified Paths:
> --------------
>     trunk/base/src/macports1.0/macports.tcl
> 
> Modified: trunk/base/src/macports1.0/macports.tcl
> ===================================================================
> --- trunk/base/src/macports1.0/macports.tcl	2014-08-14 03:32:10 UTC (rev 123767)
> +++ trunk/base/src/macports1.0/macports.tcl	2014-08-14 04:34:03 UTC (rev 123768)
> @@ -2345,7 +2345,7 @@
>                      } else {
>                          set git_action "pull --rebase"
>                      }
> -                    set git_commandline "pushd $portdir ; $git_cmd $git_action ; popd"
> +                    set git_commandline "sh -c 'cd $portdir && $git_cmd $git_action || true'"
>                      ui_debug $git_commandline
>                      if {
>                          [catch {

Do we really need to call 'sh -c' here? And is the '|| true' needed
given that the 'system $git_commandline' is wrapped in a catch? And
would it be better to replace the 'cd $portdir' with a -W arg to system,
or do we want to see it in the ui_debug output?

- Josh