[129507] trunk/dports/multimedia/mpv/Portfile

[Ryan Schmidt]

> On Dec 14, 2014, at 6:26 PM, ionic at macports.org wrote:
> 
> Revision
> 129507
> Author
> ionic at macports.org
> Date
> 2014-12-14 16:26:55 -0800 (Sun, 14 Dec 2014)
> Log Message
> 
> mpv: inline waf fetching.
> Modified Paths
> 
> 	• trunk/dports/multimedia/mpv/Portfile
> Diff
> 
> Modified: trunk/dports/multimedia/mpv/Portfile (129506 => 129507)
> 
> --- trunk/dports/multimedia/mpv/Portfile	2014-12-15 00:11:38 UTC (rev 129506)
> +++ trunk/dports/multimedia/mpv/Portfile	2014-12-15 00:26:55 UTC (rev 129507)

> +set waf_version         1.8.1
> +set waf_distfile        waf-${waf_version}
> +set mpv_distfile        ${distfiles}
> +master_sites-append     http://ftp.waf.io/pub/release:waf
> +distfiles-append        ${waf_distfile}:waf
>  
> +extract.only-delete     ${waf_distfile}
> +
> +checksums               ${mpv_distfile} \
> +                        rmd160  0c34377f400bdb05536666866418442c32792866 \
> +                        sha256  e7aa04852944eae4ebe0c38da83093e757f04741b98b3dd2cc4c2cdd3cea3e91 \
> +                        ${waf_distfile} \
> +                        rmd160  d74bf5e8b2399098aef8e9bf57fb800a473be6a1 \
> +                        sha256  ec658116ba0b96629d91fde0b32321849e866e0819f1e835c4c2c7f7ffe1a21d
> 

Thanks. How common do you think this is -- port downloads waf before using it? Might we need this in other ports as well?


> -pre-configure {
> -    system -W "${worksrcpath}" "${waf.python} bootstrap.py"
> +post-extract {
> +    xinstall -m 0644 -W "${distpath}" "${waf_distfile}" "${worksrcpath}/waf"
>  }

Remember, as Larry said in response to another commit, that these quotation marks are unnecessary, even if the values of the variables contain spaces, which they don't anyway, so the quotation marks should be removed, so as not to give the mistaken impression to others reading the portfile as an example that the quotes are in some way helpful or needed. If this were a shell script, the quotation marks would prevent problems when the variable value contains spaces, but in Tcl that is not a problem.