[129507] trunk/dports/multimedia/mpv/Portfile

[Brandon Allbery]

On Sun, Dec 14, 2014 at 7:50 PM, Ryan Schmidt <ryandesign at macports.org>
wrote:
>
> > -pre-configure {
> > -    system -W "${worksrcpath}" "${waf.python} bootstrap.py"
> > +post-extract {
> > +    xinstall -m 0644 -W "${distpath}" "${waf_distfile}"
> "${worksrcpath}/waf"
> >  }
>
> Remember, as Larry said in response to another commit, that these
> quotation marks are unnecessary, even if the values of the variables
> contain spaces, which they don't anyway, so the quotation marks should be
> removed, so as not to give the mistaken impression to others reading the
> portfile as an example that the quotes are in some way helpful or needed.
> If this were a shell script, the quotation marks would prevent problems
> when the variable value contains spaces, but in Tcl that is not a problem.
>

If we're going to be pedantic, the braces around the variable names don't
do anything except in the case of ${waf.python} where they are required.

-- 
brandon s allbery kf8nh                               sine nomine associates
allbery.b at gmail.com                                  ballbery at sinenomine.net
unix, openafs, kerberos, infrastructure, xmonad        http://sinenomine.net
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20141214/e668e610/attachment.html>