[129507] trunk/dports/multimedia/mpv/Portfile

[Mihai Moldovan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 15.12.2014 01:50 AM, Ryan Schmidt wrote:
> Thanks. How common do you think this is -- port downloads waf before using 
> it? Might we need this in other ports as well?

I only had a superficial look, but it seems not be common. Most software bundles
waf directly, so that's a non-problem. I'd have to check more in depth, though.


>> -pre-configure {
>> -    system -W "${worksrcpath}" "${waf.python} bootstrap.py"
>> +post-extract {
>> +    xinstall -m 0644 -W "${distpath}" "${waf_distfile}" "${worksrcpath}/waf"
>> }
> 
> Remember, as Larry said in response to another commit, that these quotation 
> marks are unnecessary, even if the values of the variables contain spaces, 
> which they don't anyway, so the quotation marks should be removed, so as not 
> to give the mistaken impression to others reading the portfile as an example 
> that the quotes are in some way helpful or needed. If this were a shell 
> script, the quotation marks would prevent problems when the variable value 
> contains spaces, but in Tcl that is not a problem.


Yes, but until I issue a commit changing that in all places at once, I want it
to be consistent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJUjjM4AAoJEB/WLtluJTqHNkEP/ju/1Y1q8EIyzSmX/Yq/Hglk
aNjHDIgllq9ezjpJ/QGG90iSHYejh5HHs2TBeKjUhj+dEoD8OPDqoHylfjySmS+9
IGtyJAoiLE8HliDoEE8kYaMF812/HZ4e+TzV5Dq6ZZxHaffKNH5IglcwuLBBLRVQ
c4VKB+8eFdL9UskDt0NSi+qwqU4cxtpEu5E5XAjnc9Kr8ogSfScs5YYJzug0Q747
iy3I2Zx9zXL+KSm7rMvl9fC0v/L4atrPPC5VlAbyp11Z+XlM+S7SXshXiT8v8gWz
DNAYSQJpat31qnVEkFaVyTG5cc2eOO9rpgtYPZTD/jSE+f9tjckIE9P0UAmLwd1a
9jPa36+yabq556e1qcIObIA3HEBlhPZ/1f9WOCxm4JHMAMDw42ySRYxdnWy4TPQI
UuglP4XPR6R2LM9jdlO/ALLPv5w3m3PO6W1T8UwI+wDbxMTQ8YG/ksaMuhQGNTi2
d4dntFEk6ltq1hW0sPXEJsm7awFcwgVJZH738tyq+2q5D2wtRZgzPD1F5ozue9+y
q6KR+TFUYbaUoL+faxb+3WQ6+NA3dkA3X5HXl1ZVql+b+MHJSamhUzl2twTCI+gd
6eICgPwdoIQZxfsqjfjSgVc8M1XtvbEv3w9BGdKuLR1gJ0MNDQhwTUD9+lfHZpiG
rwGS2KijDoJCsWXR2XeE
=1nbN
-----END PGP SIGNATURE-----