[115835] trunk/dports/audio/xmp/Portfile

[Jeremy Huddleston Sequoia]

The library filename and dylib should only change if the new library is not backwards compatible with code linked against the old one.

Ideally:

libxmp.dylib should be a symlink to libxmp.4.dylib
libxmp.4.dylib should be the real filename with a dylib id of ${prefix}/lib/libxmp.4.dylib
libxmp.4.dylib should have a valid compatibility version and current version (probably compat = 4.0.0 and current = 4.2.2 in this case).

Based on what they're doing for other platforms, this patch seems right:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dylibid.patch
Type: application/octet-stream
Size: 1774 bytes
Desc: not available
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20140112/066f8282/attachment-0001.obj>
-------------- next part --------------


--Jeremy

On Jan 12, 2014, at 14:24, Douglas Carmichael <dcarmich at dcarmichael.net> wrote:

> Ryan, Jeremy:
> 
> I have contacted the upstream developer and notified him of the library versioning issue.
> 
> How would he version the library within the build process?
> 
> —Douglas
> 
> On Jan 12, 2014, at 4:23 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
>> On Jan 12, 2014, at 16:14, Jeremy Huddleston Sequoia wrote:
>> 
>>> This changed the dylib id of libxmp.dylib and breaks dependent ports.
>> 
>> Which is only xmp, as far as I can tell, right? I increased its revision:
>> 
>> https://trac.macports.org/changeset/115842
>> 
>> 
>>> It looks like upstream doesn't know how to version libraries since the dylib version matches the project version.
>> 
>> Yeah, and they use the full three-part version number in the library file name, so even minor version updates will need dependents to be rebuilt.
>> 
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4136 bytes
Desc: not available
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20140112/066f8282/attachment-0001.p7s>