[121029] trunk/dports/multimedia

[Ryan Schmidt]

On Jun 14, 2014, at 6:42 PM, mf2k at macports.org wrote:

> Revision
> 121029
> Author
> mf2k at macports.org
> Date
> 2014-06-14 16:42:28 -0700 (Sat, 14 Jun 2014)
> Log Message
> 
> audacious audacious-core audacious-plugins: New ports. (#25260)


> --- trunk/dports/multimedia/audacious-core/Portfile	                        (rev 0)
> +++ trunk/dports/multimedia/audacious-core/Portfile	2014-06-14 23:42:28 UTC (rev 121029)

> +depends_build       path:bin/pkg-config:pkgconfig \
> +                    path:bin/aclocal:automake \
> +                    path:bin/autom4te:autoconf

> +use_autoreconf      yes
> +autoreconf.cmd      ./autogen.sh
> +autoreconf.args

libtool is also usually needed to autoreconf. You should verify whether this port builds ok when libtool is deactivated; if not, add the libtool build dependency as well.


> +platform darin {

"darwin" is misspelled.


> +    if {[info exists configure.cxx_stdlib] &&

Now that MacPorts 2.3.0 has been released, configure.cxx_stdlib does exist, so there's no need to check for it.


> --- trunk/dports/multimedia/audacious-plugins/Portfile	                        (rev 0)
> +++ trunk/dports/multimedia/audacious-plugins/Portfile	2014-06-14 23:42:28 UTC (rev 121029)

The same comments as above apply to this port, and also:


> +default_variants    +full +sdl1

+sdl1 should only be selected if the user has not already selected conflicting variant +sdl2.