Clang: Mavericks v. the rest (was Re: buildbot failure in MacPorts on buildports-mavericks-x86_64)

[Lawrence Velázquez]

On Oct 14, 2014, at 9:22 PM, Craig Treleaven <ctreleaven at macports.org> wrote:

> Mavericks Clang errors out with the following:
> 
> test_dr.c:49:3: error: comparison of constant 12 with expression of type 'bool' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
>   BOZO_end_boolean(b_multiple_frame_rate)
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./test_dr.h:102:39: note: expanded from macro 'BOZO_end_boolean'
>     } while(!i_err && (s_decoded.name <= 12));                          \
>                        ~~~~~~~~~~~~~~ ^  ~~
> (Complete log from the Mavericks buildbot attached.)
> 
> If I understand correctly (always dicey given I'm not a C developer), this is a unit test with (I guess) an awkward construct.  The thing is, Clang on MtnLion doesn't complain at all on the same code.
> 
> What would be the best way to get past this?

Patch or reinplace the -Werror flags out of the build.

vq