Clang: Mavericks v. the rest (was Re: buildbot failure in MacPorts on buildports-mavericks-x86_64)

[Chris Jones]

Hi,

The warning is correct. If s_decoded.name is a boolean then 
s_decoded.name <= 12 is always true. OSX10.9 has a newer clang, which 
issues a warning in this case 
(-Wtautological-constant-out-of-range-compare), older OSes have older 
clang versions that do not. Finally -Werror turns it into an error.

So basically its a bug in the code which should be reported upstream to 
get fixed.

Chris

On 15/10/14 02:22, Craig Treleaven wrote:
> At 2:39 PM -0700 10/14/14, noreply at macports.org wrote:
>> The Buildbot has detected a failed build on builder
>> buildports-mavericks-x86_64 while building MacPorts.
>> Full details are available at:
>>  http://build.macports.org/builders/buildports-mavericks-x86_64/builds/7702
>
> Can some kind person (Jeremy?) help me understand why the version of
> Clang on the Mavericks buildbot is falling over while the Lion and
> MtnLion versions don't even spit a warning?
>
> Mavericks Clang errors out with the following:
>
> test_dr.c:49:3: error: comparison of constant 12 with expression of type
> 'bool' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
>    BOZO_end_boolean(b_multiple_frame_rate)
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./test_dr.h:102:39: note: expanded from macro 'BOZO_end_boolean'
>      } while(!i_err && (s_decoded.name <= 12));      \
> ~~~~~~~~~~~~~~ ^  ~~
> (Complete log from the Mavericks buildbot attached.)
>
> If I understand correctly (always dicey given I'm not a C developer),
> this is a unit test with (I guess) an awkward construct. The thing is,
> Clang on MtnLion doesn't complain at all on the same code.
>
> What would be the best way to get past this?
>
> Thanks,
>
> Craig
>
>
> _______________________________________________
> macports-dev mailing list
> macports-dev at lists.macosforge.org
> https://lists.macosforge.org/mailman/listinfo/macports-dev
>