base: improve livecheck.type moddate (review request)

[Bradley Giesbrecht]

On Sep 12, 2014, at 1:03 AM, Joshua Root <jmr at macports.org> wrote:

> On 2014-9-12 14:31 , Bradley Giesbrecht wrote:
>> MacPorts Devs,
>> 
>> 
>> I am seeking comments on the patches [1][2] to port livecheck in ticket 44894 [3].
>> 
>> In curl.c, the getmoddate function is copied from the isnewer function with minor changes to return the remote file moddate.
>> 
>> In portfilecheck.tcl, I have add a "livecheck.type moddate2" for testing. I have attempted to have moddate2 default to the current behavior or moddate.
>> 
>> The goal is to improve "livecheck.type moddate" by making the comparison date settable in the Portfile as opposed to the current behavior of only using the Portfile mtime for comparison.
>> 
>> The ticket 44894 has example usage in comment 1.
>> 
>> 
>> [1] https://trac.macports.org/attachment/ticket/44894/patch-base-src-port1.0-portlivecheck.tcl.diff
>> [2] https://trac.macports.org/attachment/ticket/44894/patch-base-src-pextlib1.0-curl.c.diff
>> [3] https://trac.macports.org/ticket/44894#comment:1
> 
> Please don't just add another copy of mostly identical code. Instead,
> modify isnewer to use getmoddate.

I want to replace isnewer with getmoddate.


Regards,
Bradley Giesbrecht (pixilla)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20140912/70c4cc36/attachment-0001.sig>