imake

[Joshua Root]

On 2014-9-28 13:55 , Brandon Allbery wrote:
> On Sat, Sep 27, 2014 at 11:47 PM, Joshua Root <jmr at macports.org
> <mailto:jmr at macports.org>> wrote:
> 
>     That isn't the issue AFAICT, it's just doing things with comments that
>     were probably undefined before and now don't work:
> 
> 
> That is in fact closely related to the issue. The old K&R preprocessor
> allowed that as a hack; ANSI C required that comments expand to spaces,
> and provided new # and ## operations for token splicing --- but these
> require valid C tokens.
> 
>     # define ProjectRulesFile       Concat3(<,TopLevelProject,.rules>)
> 
> may happen to work if you update it to use ANSI token splicing --- but I
> doubt it, since it's designed for valid C tokens and you're trying to
> generate a single invalid C token.

It does, with a little tweaking. But you're still right, it then
proceeds to screw up the indentation in the Makefile.

> Also watch what happens with single quoted strings when xmkmf expands
> macros in Imakefiles.

Yeah, that's already been patched.

- Josh