[135005] trunk/dports/x11/xinit/Portfile

[Mihai Moldovan]

[Resent to the mailing list only]

On 13.04.2015 05:10 PM, Mihai Moldovan wrote:
> On 13.04.2015 05:01 PM, Lawrence Velázquez wrote:
>> On Apr 13, 2015, at 10:38 AM, Mihai Moldovan <ionic at macports.org> wrote:
>>
>>> The "problem" is that this is not a real "block" but a list element.
>>> While a newline at the beginning is generally ignored by the notes base
>>> code, newlines at the end are not. Not escaping a newline there is thus
>>> leading to output like this:
>>>
>>> "xinit has the following notes:
>>>  To choose MacPorts' X11 as the default server, you must install
>>> xorg-server,
>>>
>>>  logout, and log back in.
>>>
>>> "
>> That's not the only problem with xinit's notes — they're entirely broken. Each "notes-append" you do creates its own separate block of text that the notes code formats/wraps individually.
> I'm open to suggestions.
>
> If individual notes-append "blocks" creates own separate list elements,
> notes-append is not really useful in most circumstances. The only
> workaround I see is using
>
> notes [concat {*}"${notes} new content"]
>
> to flatten the lists into one string every single time, but that's fugly.

Maybe the best way to create notes blocks is to compose the block via a
unique variable like this:

set note_block "foo"
note_block-append "bar"

and pass a single string to notes:

notes-append [concat {*}${note_block}]



Mihai





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20150413/08590716/attachment.sig>