[138221] trunk/dports/multimedia/mpv

[Ryan Schmidt]

> On Jul 2, 2015, at 11:14 AM, ionic at macports.org wrote:
> 
> Revision
> 138221
> Author
> ionic at macports.org
> Date
> 2015-07-02 09:14:19 -0700 (Thu, 02 Jul 2015)
> Log Message
> 
> mpv: update to 0.9.2. (By extension) Fixes: #48221.
> 
>   - Remove unused variants:
>     o lirc
>     o mp3
>   - Add new variants:
>     o rubberband
>   - Regenerate patchset.
>   - Add new patch for light sensor notifications on OS X 10.6.

> Modified: trunk/dports/multimedia/mpv/Portfile (138220 => 138221)
> --- trunk/dports/multimedia/mpv/Portfile	2015-07-02 16:12:42 UTC (rev 138220)
> +++ trunk/dports/multimedia/mpv/Portfile	2015-07-02 16:14:19 UTC (rev 138221)

> +# Remove after 06-28-2016.
> +variant mp3 description {Legacy compatibility variant for MP3 support via mpg123. Will be removed soon.} {
> +    notes-append "
> +                   You have enabled the legacy mp3 variant.
> +                   Upstream ceased using mpg123 in version 0.8.0 and removed support
> +                   completely in 0.9.0.
> +                   Decoding and playback of MP3 content is still available via
> +                   ffmpeg, so no action is needed on your side.
> +                 "
>  }

If no action is needed on the user's part to continue to get mp3 support, then there is no reason not to remove the variant immediately. Keeping the variant only serves to confuse the user by printing a pointless message, and causes the user to have a non-default set of variants, meaning if there were binaries of this port, the user wouldn't be able to get them until they manually deselected this variant.