Buildbot cruft: /opt/local/bin/mvn31

[Blair Zajac]

On Mar 17, 2015, at 11:40 PM, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
> On Mar 18, 2015, at 1:30 AM, Mojca Miklavec wrote:
>> 
>> On Wed, Mar 18, 2015 at 7:09 AM, Ryan Schmidt wrote:
>>> On Mar 17, 2015, at 3:24 PM, Blair Zajac wrote:
>>>> 
>>>> Funny, I found this code in the maven3 port because of this bug:
>>>> 
>>>> pre-activate {
>>>>  # Remove stray files on Mavericks buildbot
>>>>  foreach file {bin/mvn3} {
>>>>      set filepath ${prefix}/${file}
>>>>      if {[file exists ${filepath}] && [registry_file_registered ${filepath}] == "0"} {
>>>>          delete ${filepath}
>>>>      }
>>>>  }
>>>> }
>>>> 
>>>> I’ll put this in maven31 for an hour and then remove it.
>>> 
>>> If these crufty files are present on the buildbot builders, then they are probably also present on the system of any user who installed the port.
>> 
>> No, not necessarily. The files could also be present because of a
>> failure on the buildbot (if the build was broken in the middle of
>> activation step for example, so that files ended up on the system, but
>> they were never registered).
>> 
>> I'm not saying this is the case here, but it often is.
> 
> We know that's not the case here. We know the problem was caused by a line in the destroot block that copied a file directly into prefix, bypassing destroot. This was fixed in r134042 but anybody who installed the port before that will experience an activation error when upgrading to any newer version. A fix for the activation error was committed in r134059, but removed again in r134074. The fix should be re-committed and kept for a minimum of one year.

Restored in r134113.

Blair