[135847] trunk/dports/science/volk

[Ryan Schmidt]

> On May 5, 2015, at 10:06 AM, michaelld at macports.org wrote:
> 
> Revision
> 135847
> Author
> michaelld at macports.org
> Date
> 2015-05-05 08:06:12 -0700 (Tue, 05 May 2015)
> Log Message
> 
> volk:
> + update to 83b09941 (20150504);
> + remove now-unnecessary patch, instead blacklisting GCC < 4.3 since they do not provide <cpuid.h>, which is now a required header when compiling using GCC.
> 
> Modified Paths
> 
> 	• trunk/dports/science/volk/Portfile

> +PortGroup           compiler_blacklist_versions 1.0

> @@ -29,11 +30,10 @@
>  depends_build-append port:pkgconfig
>  depends_lib-append   port:boost
>  
> -# temporary patch to add lib/gcc_x86_cpuid.h back to the repo, since
> -# it is needed by some older GCC compilers. It does not hurt newer
> -# ones that provide cpuid.h.
> +# blacklist GCC < 4.3, since it does not provide <cpuid.h>, which is a
> +# required header when compiling using GCC as of 4c967ef1 (2015-05-04).
>  
> -patchfiles-append   patch-lib_gcc_x86_cpuid.h.diff
> +compiler.blacklist-append {*gcc-3*} {*gcc-4.[0-2]}
>  
>  # do VPATH (out of source tree) build
>  
> @@ -125,8 +125,9 @@
>  
>          # Blacklist GCC compilers not supporting C++11 and all CLANG.
>          # This is probably not necessary, but it's good practice.
> +        # GCC 3* and 4.[0-2] are already blacklisted above.
>  
> -        compiler.blacklist-append *clang* {*gcc-3*} {*gcc-4.[0-6]}
> +        compiler.blacklist-append *clang* {*gcc-4.[3-6]}


It doesn't look like you're using the capabilities of the compiler_blacklist_versions portgroup here.

There shouldn't be any need to enclose these blacklist values in curly brackets. Quoting is only needed when a value contains spaces, which these values do not.

In the context of Tcl I'm unfamiliar with the "[3-6]" notation that you're using so I'm not sure how or if that works. If it works, then I understand the use of curly brackets to quote them, because otherwise the square brackets would be interpreted as a request to run a Tcl procedure. Blacklisting gcc 4.3 and greater is probably never needed since there is no circumstance in which MacPorts would have chosen that compiler anyway.