[135847] trunk/dports/science/volk

[Lawrence Velázquez]

On May 5, 2015, at 2:49 PM, Ryan Schmidt <ryandesign at macports.org> wrote:

> It doesn't look like you're using the capabilities of the compiler_blacklist_versions portgroup here.

Doesn't look like it, so the portgroup is unnecessary.

> In the context of Tcl I'm unfamiliar with the "[3-6]" notation that you're using so I'm not sure how or if that works.

The elements of compiler.blacklist are treated as patterns for "string match", which closely resemble shell globs.

http://www.tcl.tk/man/tcl8.5/TclCmd/string.htm#M39

So this matches (and thus blacklists) GCC 4.0, 4.1, and 4.2:

    compiler.blacklist {*gcc-4.[0-2]}

> If it works, then I understand the use of curly brackets to quote them, because otherwise the square brackets would be interpreted as a request to run a Tcl procedure.

Right. Asterisks and hyphens don't have to be quoted, but brackets do.

> Blacklisting gcc 4.3 and greater is probably never needed since there is no circumstance in which MacPorts would have chosen that compiler anyway.

I've done this before in the name of thoroughness, but it's generally not necessary.

vq