[136192] trunk/dports/sysutils/synergy

[Ryan Schmidt]

On May 11, 2015, at 7:22 PM, Dan Ports wrote:

> On Mon, May 11, 2015 at 06:36:06PM -0500, Ryan Schmidt wrote:
>>> Modified: trunk/dports/sysutils/synergy/Portfile (136191 => 136192)
>> 
>>> +set major               [lindex [split ${macosx_version} .] 0]
>>> +set minor               [lindex [split ${macosx_version} .] 1]
>>> +configure.args -G \"Unix Makefiles\" \
>>> +               -DOSX_TARGET_MAJOR=${major} -DOSX_TARGET_MINOR=${minor}
>> 
>> Did you mean to overwrite the configure.args the cmake portgroup sets? Usually when using the cmake portgroup you should append to configure.args rather than overwriting them.
> 
> Yes -- IIRC there was something in the usual cmake configure.args that
> was causing problems, but I forgot what it was.
> 
> (I made these changes a couple weeks ago, then went off for a while
> before committing, giving me ample time to forget...)

I tried it just now; worked fine with:



Index: Portfile
===================================================================
--- Portfile	(revision 136210)
+++ Portfile	(working copy)
@@ -37,8 +37,8 @@
 
 set major               [lindex [split ${macosx_version} .] 0]
 set minor               [lindex [split ${macosx_version} .] 1]
-configure.args -G \"Unix Makefiles\" \
-               -DOSX_TARGET_MAJOR=${major} -DOSX_TARGET_MINOR=${minor}
+configure.args-append   -DOSX_TARGET_MAJOR=${major} \
+                        -DOSX_TARGET_MINOR=${minor}
 
 use_parallel_build no
 


Could you try that and let me know if it works for you too? (Though I don't really see what they're doing with OSX_TARGET_MAJOR and OSX_TARGET_MINOR, other than requiring that OSX_TARGET_MAJOR is "10", which is funny. The checks for OSX_TARGET_MINOR are being removed by a patch. Maybe we could patch out OSX_TARGET_MAJOR and OSX_TARGET_MINOR entirely.)


I see they're already up to 1.7.2. Maybe I'll try updating to that. There are a bunch of other changes I had waiting to be incorporated as well.